Bug #40

Fix for uneven spaced torque curve points

Added by tdev over 2 years ago. Updated about 1 year ago.

Status:Closed Start date:12/17/2009
Priority:High Due date:
Assignee:flypiper % Done:

100%
Category:RoR - Graphics
Target version:0.38
Operating System:All Operating System Bits:

Description

with the current implementation, the points needed to be spaced evenly, otherwise the torque curve is distorted.
This patch calculates a new, evenly spaced spline via linear interpolation.
Thanks to Miura, who found the reason for the distorted curves!

EDIT:forum post about the problem: http://forum.rigsofrods.com/index.php?topic=24070.0

It also corrects the calculation of the rpm ratio (actRPM/maxRPM), because the maximum RPM of the engine is not the maxRPM, it is (maxRPM*1.25).

torquecurve_patch.patch (4.5 kB) Magnifier tdev, 12/17/2009 11:51 am

Associated revisions

Revision 1698
Added by tdev about 1 year ago

fixes #40

History

#1 Updated by tdev about 2 years ago

  • Target version set to 0.37
  • Operating System set to All
  • 2 set to 0.37.x

#2 Updated by tdev almost 2 years ago

  • Status changed from New to Researching
  • Assignee changed from tdev to Aperion
  • % Done changed from 0 to 10

could you look at this please?

#3 Updated by Aperion almost 2 years ago

tdev wrote:

could you look at this please?

sure, no problem.

Edit:
I read the patch, my concern is the linear interpolating, I think that would remove most of the curvature done by the simple spline. although I havn't used the patch so I'm not sure how big of an issue this it. Perhaps another type of interpretation could be used instead of the simple spline. Perhaps a more robust spline model could also be used on procedural roads.

#4 Updated by tdev almost 2 years ago

  • Target version deleted (0.37)

#5 Updated by tdev about 1 year ago

  • Target version set to 0.38
  • % Done changed from 10 to 90

we need to merge this

#6 Updated by tdev about 1 year ago

  • Assignee changed from Aperion to flypiper

#7 Updated by Anonymous about 1 year ago

  • Status changed from Researching to Closed
  • % Done changed from 90 to 100

Applied in changeset r1698.

Also available in: Atom PDF