Bug #269: Ingame Friction Editor Bugs and Suggestions. - Rigs of Rods - Redmine

Bug #269

Bug #402: fix and improve ground and friction in 0.37-r1

Ingame Friction Editor Bugs and Suggestions.

Added by 1crash007 about 2 years ago. Updated 9 months ago.

Status:

Closed

Start date:

05/19/2010

Priority:

Normal

Due date:

Assignee:

Aperion

% Done:

100%

Category:

RoR - Graphics

Target version:

0.39

Operating System:

Windows 7

Operating System Bits:

32 Bit

Description

Bugs:
1 adhesion velocity and dynamic velocity sliders should nearly be the same Adhesion 0 to 0.5 change to 0 to 1.5
2 Static friction only goes up to 2 Should at least go to 4 at most or 3.
Fx_Type is old it reads clumpy dusty and something else. Recommend it reads them after parsing the particles to get proper names.
Fx_Color Broken cannot change color.
No option to enable or disable particle.

ape-frictiongui-cleanupv4.patch (42 kB) Aperion, 05/27/2010 01:42 am

History

#1 Updated by Aperion about 2 years ago

Category changed from RoR - Physics to RoR - GUI
Assignee changed from tdev to Aperion

Will take a look at this tonight, does not sound like major changes would be needed. And a good opportunity for me to get used other non-physics related parts of RoR.

#2 Updated by 1crash007 about 2 years ago

Aperion wrote:

Will take a look at this tonight, does not sound like major changes would be needed. And a good opportunity for me to get used other non-physics related parts of RoR.

Better get cracking those fingers. Looks like it will be great once its working better.
If you could make a config for the ingame traction editor that would help out too.

Edit: one more thing i forgot to mention change the increments to increase and decrease.
Stribeck is fine default=1
Adhesion change to 0.25 per click
Same for other upper settings.

Lower ones change then to 0.01 for drag and for others increments of 10
Fluid type min -2 max 2 with increments of 0.1
thanks Aperion for doing this.

#3 Updated by tdev about 2 years ago

Target version set to 0.37
% Done changed from 0 to 10

#4 Updated by Aperion about 2 years ago

Category changed from RoR - GUI to RoR - Graphics
Status changed from New to Researching
Target version deleted (~~0.37~~)
% Done changed from 10 to 0

I'm investigating this but I'm hesitant to make the changes in maximums and minimum, it matches the values specified in the wiki, especially the 0 value for adhesion velocity. Was this changed and the wiki not updated? can you provide a forum post for where these values changed?

looking into increment changes.

#5 Updated by Aperion about 2 years ago

File ape-frictiongui-cleanup.patch added
% Done changed from 0 to 60

Did some clean-up of the code to make it easier to read and to follow the "Do not repeat your self" moto

Making these changes should now be trivial, but I'd still like to very the changes.

Please verify that these changes act the same as the old code.

#6 Updated by Aperion about 2 years ago

Target version set to 0.37

oops noticed I removed the target version.

#7 Updated by 1crash007 almost 2 years ago

Aperion wrote:

oops noticed I removed the target version.

Shouldnt it be SVN? or maybe .38 so that it can be perfected first?

#8 Updated by Aperion almost 2 years ago

1crash007 wrote:

Aperion wrote:

oops noticed I removed the target version.

Shouldnt it be SVN? or maybe .38 so that it can be perfected first?

Well this issue isn't about the friction code, just the GUI. Plus thomas set it to 0.37 so I was setting it back to that. I really think 0.37 is fine for this type of issue.

#9 Updated by Aperion almost 2 years ago

File ape-frictiongui-cleanupv2.patch added

More cleanup for testing, to check between the changes and the original code change

#define REDUCTION 1

#define REDUCTION 0

#10 Updated by estama almost 2 years ago

I think that 1crash is right (and the wiki needs changing to conform to to the new GUI limits he is taking about). The information in the wiki is based on an earlier forum post of mine, which was written based on RL experimental limits.

The thing is that i've done a quick analysis of RoR's resulting friction curves (i haven't found time to write about this), and i now understand that there is a need to have bigger limits on these things.

In general, i believe that in these things, the people that "design/define" the parameters of the various ground types should be listened upon. Their work is difficult enough already, and imposing limits on it makes it even more difficult.

The only thing that i should warn against is with defining the parameters for the various ground types based on the various unnaturally weighting RoR trucks. This will make normal weighting trucks to behave like they have unnaturally large friction.

#11 Updated by Aperion almost 2 years ago

estama wrote:

I think that 1crash is right (and the wiki needs changing to conform to to the new GUI limits he is taking about). The information in the wiki is based on an earlier forum post of mine, which was written based on RL experimental limits.

The thing is that i've done a quick analysis of RoR's resulting friction curves (i haven't found time to write about this), and i now understand that there is a need to have bigger limits on these things.

In general, i believe that in these things, the people that "design/define" the parameters of the various ground types should be listened upon. Their work is difficult enough already, and imposing limits on it makes it even more difficult.

The only thing that i should warn against is with defining the parameters for the various ground types based on the various unnaturally weighting RoR trucks. This will make normal weighting trucks to behave like they have unnaturally large friction.

Thank you for chiming in. With the cleanup patch these change will take ~5 minutes.

BTW, for Adhesion velocity did you mean 0.25 or 0.025? 0.25 sound like a large jump relative to the range.

#12 Updated by Aperion almost 2 years ago

File ape-frictiongui-cleanupv3.patch added
Status changed from Researching to requires testing
% Done changed from 60 to 90

New patch with latest value changes
Adhesion velocity range from 0.1 to 1.5
static friction max is set to 4
all upper values increment at 0.25 per tick with the exception of stribeck, it is set at an increment of 1

lower values
fluid type/behavior is set with an increment of 0.1, Drag 0.01 and all other lower values increments of 10.

Patch is ready for testing and them merging.